From 161078ed900493f028e06ffc7efc3c5f816374d6 Mon Sep 17 00:00:00 2001
From: Alexandre Pujol <alexandre@pujol.io>
Date: Sat, 1 Mar 2025 13:18:19 +0100
Subject: [PATCH] tests: move common cloud-init config to a unified file,
 rename some base distribution.

---
 .../cloud-init/archlinux-cosmic.user-data.yml | 15 --------
 .../cloud-init/archlinux-gnome.user-data.yml  | 15 --------
 tests/cloud-init/archlinux-kde.user-data.yml  | 15 --------
 .../cloud-init/archlinux-server.user-data.yml | 15 --------
 tests/cloud-init/archlinux-xfce.user-data.yml | 15 --------
 tests/cloud-init/common.yml                   | 17 +++++++++
 ...-data.yml => debian12-gnome.user-data.yml} | 15 --------
 ...er-data.yml => debian12-kde.user-data.yml} | 15 --------
 ...data.yml => debian12-server.user-data.yml} | 15 --------
 tests/cloud-init/opensuse-gnome.user-data.yml | 15 --------
 tests/cloud-init/opensuse-kde.user-data.yml   | 15 --------
 .../cloud-init/opensuse-server.user-data.yml  | 36 +++++++++++++++++++
 .../cloud-init/ubuntu22-desktop.user-data.yml | 15 --------
 .../cloud-init/ubuntu24-desktop.user-data.yml | 17 ---------
 .../cloud-init/ubuntu24-server.user-data.yml  | 15 --------
 15 files changed, 53 insertions(+), 197 deletions(-)
 create mode 100644 tests/cloud-init/common.yml
 rename tests/cloud-init/{debian-gnome.user-data.yml => debian12-gnome.user-data.yml} (74%)
 rename tests/cloud-init/{debian-kde.user-data.yml => debian12-kde.user-data.yml} (68%)
 rename tests/cloud-init/{debian-server.user-data.yml => debian12-server.user-data.yml} (73%)
 create mode 100644 tests/cloud-init/opensuse-server.user-data.yml

diff --git a/tests/cloud-init/archlinux-cosmic.user-data.yml b/tests/cloud-init/archlinux-cosmic.user-data.yml
index d95381b96..70d446076 100644
--- a/tests/cloud-init/archlinux-cosmic.user-data.yml
+++ b/tests/cloud-init/archlinux-cosmic.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   # Install core packages
   - apparmor
diff --git a/tests/cloud-init/archlinux-gnome.user-data.yml b/tests/cloud-init/archlinux-gnome.user-data.yml
index a2a3d78b8..1fa1c9c1d 100644
--- a/tests/cloud-init/archlinux-gnome.user-data.yml
+++ b/tests/cloud-init/archlinux-gnome.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   # Install core packages
   - apparmor
diff --git a/tests/cloud-init/archlinux-kde.user-data.yml b/tests/cloud-init/archlinux-kde.user-data.yml
index eea5df046..5953eab2e 100644
--- a/tests/cloud-init/archlinux-kde.user-data.yml
+++ b/tests/cloud-init/archlinux-kde.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   # Install core packages
   - apparmor
diff --git a/tests/cloud-init/archlinux-server.user-data.yml b/tests/cloud-init/archlinux-server.user-data.yml
index 4a7f17374..e0edaca16 100644
--- a/tests/cloud-init/archlinux-server.user-data.yml
+++ b/tests/cloud-init/archlinux-server.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   # Install core packages
   - apparmor
diff --git a/tests/cloud-init/archlinux-xfce.user-data.yml b/tests/cloud-init/archlinux-xfce.user-data.yml
index 07d87364b..e9f4a78a6 100644
--- a/tests/cloud-init/archlinux-xfce.user-data.yml
+++ b/tests/cloud-init/archlinux-xfce.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   # Install core packages
   - apparmor
diff --git a/tests/cloud-init/common.yml b/tests/cloud-init/common.yml
new file mode 100644
index 000000000..ac619c879
--- /dev/null
+++ b/tests/cloud-init/common.yml
@@ -0,0 +1,17 @@
+#cloud-config
+
+hostname: ${hostname}
+
+ssh_pwauth: true
+users:
+  - name: ${username}
+    plain_text_passwd: ${password}
+    shell: /bin/bash
+    ssh_authorized_keys:
+      - ${ssh_key}
+    lock_passwd: false
+    sudo: ALL=(ALL) NOPASSWD:ALL
+
+package_update: true
+package_upgrade: true
+package_reboot_if_required: false
diff --git a/tests/cloud-init/debian-gnome.user-data.yml b/tests/cloud-init/debian12-gnome.user-data.yml
similarity index 74%
rename from tests/cloud-init/debian-gnome.user-data.yml
rename to tests/cloud-init/debian12-gnome.user-data.yml
index 1c48eb2e9..5ce6cedf5 100644
--- a/tests/cloud-init/debian-gnome.user-data.yml
+++ b/tests/cloud-init/debian12-gnome.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - auditd
diff --git a/tests/cloud-init/debian-kde.user-data.yml b/tests/cloud-init/debian12-kde.user-data.yml
similarity index 68%
rename from tests/cloud-init/debian-kde.user-data.yml
rename to tests/cloud-init/debian12-kde.user-data.yml
index e644414fa..451068db1 100644
--- a/tests/cloud-init/debian-kde.user-data.yml
+++ b/tests/cloud-init/debian12-kde.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - auditd
diff --git a/tests/cloud-init/debian-server.user-data.yml b/tests/cloud-init/debian12-server.user-data.yml
similarity index 73%
rename from tests/cloud-init/debian-server.user-data.yml
rename to tests/cloud-init/debian12-server.user-data.yml
index 47e4d832d..aef29f579 100644
--- a/tests/cloud-init/debian-server.user-data.yml
+++ b/tests/cloud-init/debian12-server.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - auditd
diff --git a/tests/cloud-init/opensuse-gnome.user-data.yml b/tests/cloud-init/opensuse-gnome.user-data.yml
index 5e5b197bc..406b4445d 100644
--- a/tests/cloud-init/opensuse-gnome.user-data.yml
+++ b/tests/cloud-init/opensuse-gnome.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - bash-completion
diff --git a/tests/cloud-init/opensuse-kde.user-data.yml b/tests/cloud-init/opensuse-kde.user-data.yml
index 5e5b197bc..406b4445d 100644
--- a/tests/cloud-init/opensuse-kde.user-data.yml
+++ b/tests/cloud-init/opensuse-kde.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - bash-completion
diff --git a/tests/cloud-init/opensuse-server.user-data.yml b/tests/cloud-init/opensuse-server.user-data.yml
new file mode 100644
index 000000000..7699fb074
--- /dev/null
+++ b/tests/cloud-init/opensuse-server.user-data.yml
@@ -0,0 +1,36 @@
+#cloud-config
+
+packages:
+  - apparmor-profiles
+  - bash-completion
+  - distribution-release
+  - git
+  - go
+  - golang-packaging
+  - htop
+  - make
+  - rpmbuild
+  - rsync
+  - vim
+
+write_files:
+
+  # Setup shared directory
+  - path: /etc/fstab
+    append: true
+    content: |
+      0a31bc478ef8e2461a4b1cc10a24cc4 /home/user/Projects/apparmor.d  virtiofs defaults  0  1
+
+  # Network configuration
+  - path: /etc/systemd/network/20-wired.network
+    owner: "root:root"
+    permissions: "0644"
+    content: |
+      [Match]
+      Name=en*
+
+      [Network]
+      DHCP=yes
+
+      [DHCPv4]
+      RouteMetric=10
diff --git a/tests/cloud-init/ubuntu22-desktop.user-data.yml b/tests/cloud-init/ubuntu22-desktop.user-data.yml
index 75dc6349d..5f4dc69f5 100644
--- a/tests/cloud-init/ubuntu22-desktop.user-data.yml
+++ b/tests/cloud-init/ubuntu22-desktop.user-data.yml
@@ -2,21 +2,6 @@
 
 # Based on https://github.com/canonical/autoinstall-desktop
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - build-essential
diff --git a/tests/cloud-init/ubuntu24-desktop.user-data.yml b/tests/cloud-init/ubuntu24-desktop.user-data.yml
index 9f7225367..7a71b0afe 100644
--- a/tests/cloud-init/ubuntu24-desktop.user-data.yml
+++ b/tests/cloud-init/ubuntu24-desktop.user-data.yml
@@ -2,23 +2,6 @@
 
 # Based on https://github.com/canonical/autoinstall-desktop
 
-# https://github.com/canonical/ubuntu-desktop-provision/blob/main/README.md
-
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - build-essential
diff --git a/tests/cloud-init/ubuntu24-server.user-data.yml b/tests/cloud-init/ubuntu24-server.user-data.yml
index 96318214c..8e9c7bd38 100644
--- a/tests/cloud-init/ubuntu24-server.user-data.yml
+++ b/tests/cloud-init/ubuntu24-server.user-data.yml
@@ -1,20 +1,5 @@
 #cloud-config
 
-hostname: ${hostname}
-
-ssh_pwauth: true
-users:
-  - name: ${username}
-    plain_text_passwd: ${password}
-    shell: /bin/bash
-    ssh_authorized_keys:
-      - ${ssh_key}
-    lock_passwd: false
-    sudo: ALL=(ALL) NOPASSWD:ALL
-
-package_update: true
-package_upgrade: true
-package_reboot_if_required: false
 packages:
   - apparmor-profiles
   - auditd