refractor(aa): move profile specific method to the profile struct.

pkg/aa/profile.go

@@ -6,6 +6,7 @@ package aa
 
 import (
 	"maps"
+	"reflect"
 	"slices"
 	"strings"
 )
@@ -50,6 +51,67 @@ func (p *Profile) String() string {
 	return renderTemplate(tokPROFILE, p)
 }
 
+// Merge merge similar rules together.
+// Steps:
+//   - Remove identical rules
+//   - Merge rule access. Eg: for same path, 'r' and 'w' becomes 'rw'
+//
+// Note: logs.regCleanLogs helps a lot to do a first cleaning
+func (p *Profile) Merge() {
+	for i := 0; i < len(p.Rules); i++ {
+		for j := i + 1; j < len(p.Rules); j++ {
+			typeOfI := reflect.TypeOf(p.Rules[i])
+			typeOfJ := reflect.TypeOf(p.Rules[j])
+			if typeOfI != typeOfJ {
+				continue
+			}
+
+			// If rules are identical, merge them
+			if p.Rules[i].Equals(p.Rules[j]) {
+				p.Rules = append(p.Rules[:j], p.Rules[j+1:]...)
+				j--
+			}
+		}
+	}
+}
+
+// Sort the rules in a profile.
+// Follow: https://apparmor.pujol.io/development/guidelines/#guidelines
+func (p *Profile) Sort() {
+	p.Rules.Sort()
+}
+
+// Format the profile for better readability before printing it.
+// Follow: https://apparmor.pujol.io/development/guidelines/#the-file-block
+func (p *Profile) Format() {
+	const prefixOwner = "      "
+
+	hasOwnerRule := false
+	for i := len(p.Rules) - 1; i > 0; i-- {
+		j := i - 1
+		typeOfI := reflect.TypeOf(p.Rules[i])
+		typeOfJ := reflect.TypeOf(p.Rules[j])
+
+		// File rule
+		if typeOfI == reflect.TypeOf((*File)(nil)) && typeOfJ == reflect.TypeOf((*File)(nil)) {
+			letterI := getLetterIn(fileAlphabet, p.Rules[i].(*File).Path)
+			letterJ := getLetterIn(fileAlphabet, p.Rules[j].(*File).Path)
+
+			// Add prefix before rule path to align with other rule
+			if p.Rules[i].(*File).Owner {
+				hasOwnerRule = true
+			} else if hasOwnerRule {
+				p.Rules[i].(*File).Prefix = prefixOwner
+			}
+
+			if letterI != letterJ {
+				// Add a new empty line between Files rule of different type
+				hasOwnerRule = false
+				p.Rules = append(p.Rules[:i], append([]Rule{&RuleBase{}}, p.Rules[i:]...)...)
+			}
+		}
+	}
+}
 
 // AddRule adds a new rule to the profile from a log map.
 func (p *Profile) AddRule(log map[string]string) {